netdev - Re: [PATCH v1 1/3] rust: core abstractions for network PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <212ffb46-ddec-4f84-a121-42ad70019363@lunn.ch>
Date: Tue, 3 Oct 2023 14:45:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: gregkh@...uxfoundation.org, miguel.ojeda.sandonis@...il.com,
	netdev@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v1 1/3] rust: core abstractions for network PHY drivers

> >> The following works. If you set the phylib as a module, the rust
> >> option isn't available.
> > 
> > That does not seem wise.  Why not make the binding a module as well?
> 
> Agreed, as I wrote in the previous mail. But Rust bindings doesn't
> support such now. I suppose that Miguel has worked on a new build
> system for Rust. He might have plans.

It would be nice to get the basic Kconfig symbols in place to support
this, for when the build does support bindings in modules. And you
should be able to use the same symbols now, just with slightly
different semantics.

The binding should have its own Kconfig Symbol, something like
RUST_PHYLIB_BINDING, with a depends on RUST and a depends on
PHYLIB. At the moment that should just cause the binding to be
compile/not compiled as part of the core rust support. The dependency
on PHYLIB will also ensure it is built in the correct way.

In the future, it can be used to build the binding as a standalone
module, built in, or not at all.

The PHY driver would then have a depends on RUST_PHYLIB_BINDING.

    Andrew