netdev - Re: [PATCH bpf-next v7 6/9] bpftool: Add support for cgroup unix socket address hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c000ec4-6522-47b3-accb-e47c985a35ce@isovalent.com>
Date: Tue, 3 Oct 2023 10:47:47 +0100
From: Quentin Monnet <quentin@...valent.com>
To: Daan De Meyer <daan.j.demeyer@...il.com>, bpf@...r.kernel.org
Cc: martin.lau@...ux.dev, kernel-team@...a.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v7 6/9] bpftool: Add support for cgroup unix
 socket address hooks

Thanks! Please don't forget to update the version in the titles of the
patches in addition to the cover letter.

On 03/10/2023 10:30, Daan De Meyer wrote:
> Add the necessary plumbing to hook up the new cgroup unix sockaddr
> hooks into bpftool.
> 
> Signed-off-by: Daan De Meyer <daan.j.demeyer@...il.com>
> Acked-by: Quentin Monnet <quentin@...valent.com>
> ---
>  .../bpf/bpftool/Documentation/bpftool-cgroup.rst | 16 +++++++++++++---
>  tools/bpf/bpftool/Documentation/bpftool-prog.rst |  8 +++++---
>  tools/bpf/bpftool/bash-completion/bpftool        | 14 +++++++-------
>  tools/bpf/bpftool/cgroup.c                       | 16 +++++++++-------
>  tools/bpf/bpftool/prog.c                         |  7 ++++---
>  5 files changed, 38 insertions(+), 23 deletions(-)

> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> index 8443a149dd17..7ec4f5671e7a 100644
> --- a/tools/bpf/bpftool/prog.c
> +++ b/tools/bpf/bpftool/prog.c
> @@ -2475,9 +2475,10 @@ static int do_help(int argc, char **argv)
>  		"                 sk_reuseport | flow_dissector | cgroup/sysctl |\n"
>  		"                 cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n"
>  		"                 cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n"
> -		"                 cgroup/getpeername4 | cgroup/getpeername6 |\n"
> -		"                 cgroup/getsockname4 | cgroup/getsockname6 | cgroup/sendmsg4 |\n"
> -		"                 cgroup/sendmsg6 | cgroup/recvmsg4 | cgroup/recvmsg6 |\n"
> +		"                 cgroup/connect_unix | cgroup/getpeername4 | cgroup/getpeername6 |\n"
> +		"                 cgroup/getpeername_unix | cgroup/getsockname4 | cgroup/getsockname6 |\n"
> +		"                 cgroup/getsockname_unix | cgroup/sendmsg4 | cgroup/sendmsg6 |\n"
> +		"                 cgroup/sendmsg°unix | cgroup/recvmsg4 | cgroup/recvmsg6 | cgroup/recvmsg_unix |\n"


Typo here on "cgroup/sendmsg°unix", please fix it. The rest of the patch
still looks good to me.

Good call from Andrii on the renames, I like it better with "_unix" as
well. :)