[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZR1slAb0AQ3ayARW@kernel.org>
Date: Wed, 4 Oct 2023 15:45:56 +0200
From: Simon Horman <horms@...nel.org>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next v1 0/2] intel: format specifier cleanups
On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote:
> Clean up some warnings from the W=1 build which moves the intel
> directory back to "clean" state. This mostly involved converting to
> using ethtool_sprintf where appropriate and kasprintf in other places.
>
> The second patch goes the extra mile and cleans up -Wformat=2 warnings
> as suggested by Alex Lobakin, since those flags will likely be turned on
> as well.
>
> gcc-12 runs clean after these changes, and clang-15 still has some minor
> complaints as mentioned in patch-2.
>
> Jesse Brandeburg (2):
> intel: fix string truncation warnings
> intel: fix format warnings
>
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++-
> .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++--
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++-------
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++--
> drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++----------
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++-
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +-
> 9 files changed, 46 insertions(+), 51 deletions(-)
For series,
Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested
Powered by blists - more mailing lists