netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier cleanups

Open Source and information security mailing list archives

Message-ID: <BL0PR11MB3521CB784A9F8B8265C45F108FC9A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date: Fri, 6 Oct 2023 15:16:15 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Christophe JAILLET
	<christophe.jaillet@...adoo.fr>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier
 cleanups

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: Wednesday, October 4, 2023 3:46 PM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>
> Cc: netdev@...r.kernel.org; Christophe JAILLET
> <christophe.jaillet@...adoo.fr>; intel-wired-lan@...ts.osuosl.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier
> cleanups
> 
> On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote:
> > Clean up some warnings from the W=1 build which moves the intel
> > directory back to "clean" state. This mostly involved converting to
> > using ethtool_sprintf where appropriate and kasprintf in other places.
> >
> > The second patch goes the extra mile and cleans up -Wformat=2 warnings
> > as suggested by Alex Lobakin, since those flags will likely be turned
> > on as well.
> >
> > gcc-12 runs clean after these changes, and clang-15 still has some
> > minor complaints as mentioned in patch-2.
> >
> > Jesse Brandeburg (2):
> >   intel: fix string truncation warnings
> >   intel: fix format warnings
> >
> >  .../net/ethernet/intel/i40e/i40e_ethtool.c    |  6 ++-
> >  .../net/ethernet/intel/iavf/iavf_ethtool.c    |  8 ++--
> >  .../net/ethernet/intel/iavf/iavf_virtchnl.c   | 22 ++++-------
> >  drivers/net/ethernet/intel/ice/ice_ethtool.c  |  7 ++--
> >  drivers/net/ethernet/intel/ice/ice_ptp.c      |  4 +-
> >  drivers/net/ethernet/intel/igb/igb_ethtool.c  |  4 +-
> >  drivers/net/ethernet/intel/igb/igb_main.c     | 37 +++++++++----------
> >  drivers/net/ethernet/intel/igc/igc_ethtool.c  |  5 ++-
> > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |  4 +-
> >  9 files changed, 46 insertions(+), 51 deletions(-)
> 
> For series,
> 
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Tested-by: Simon Horman <horms@...nel.org> # build-tested
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives