lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <85e3b93c-36b2-cb4c-9438-ad05d24b3332@foss.st.com> Date: Thu, 5 Oct 2023 11:03:43 +0200 From: Christophe ROULLIER <christophe.roullier@...s.st.com> To: Conor Dooley <conor@...nel.org>, Rob Herring <robh+dt@...nel.org> CC: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Richard Cochran <richardcochran@...il.com>, Jose Abreu <joabreu@...opsys.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 02/12] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 On 9/28/23 19:17, Conor Dooley wrote: > On Thu, Sep 28, 2023 at 05:15:02PM +0200, Christophe Roullier wrote: >> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz >> This property can be used with RMII phy without cristal 50Mhz and when we >> want to select RCC clock instead of ETH_REF_CLK >> Can be used also with RGMII phy with no cristal and we select RCC clock >> instead of ETH_CLK125 >> This new property replace st,eth-clk-sel and st,eth-ref-clk-sel > I don't really see a response to Rob's comment on v2, either here or in > a reply to his email on v2: > | Certainly 1 property is better than 2 for me, but carrying 3 is not > | great. I don't understand why the we need a new property. What can't be > | supported with the existing properties? > > A sentence saying explaining exactly what the old properties do not > support that this one does, would be very helpful. > > Thanks, > Conor. I understand your remarks, the goal of the new property is to be more simple for customers/users with old properties we have lots of support to explain which one to use in which cases, now only one property to use (regardless of mode) Thanks, Christophe. >> Signed-off-by: Christophe Roullier <christophe.roullier@...s.st.com> >> --- >> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> index ca976281bfc22..67840cab02d2d 100644 >> --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> @@ -78,12 +78,21 @@ properties: >> encompases the glue register, the offset of the control register and >> the mask to set bitfield in control register >> >> + st,ext-phyclk: >> + description: >> + set this property in RMII mode when you have PHY without crystal 50MHz and want to >> + select RCC clock instead of ETH_REF_CLK. or in RGMII mode when you want to select >> + RCC clock instead of ETH_CLK125. >> + type: boolean >> + >> st,eth-clk-sel: >> + deprecated: true >> description: >> set this property in RGMII PHY when you want to select RCC clock instead of ETH_CLK125. >> type: boolean >> >> st,eth-ref-clk-sel: >> + deprecated: true >> description: >> set this property in RMII mode when you have PHY without crystal 50MHz and want to >> select RCC clock instead of ETH_REF_CLK. >> -- >> 2.25.1 >>
Powered by blists - more mailing lists