lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c8804fbe-46e7-2771-e503-4e786df2f97c@foss.st.com> Date: Thu, 5 Oct 2023 13:27:18 +0200 From: Christophe ROULLIER <christophe.roullier@...s.st.com> To: Ben Wolsieffer <ben.wolsieffer@...ring.com> CC: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Richard Cochran <richardcochran@...il.com>, Jose Abreu <joabreu@...opsys.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 08/12] net: ethernet: stmmac: stm32: support the phy-supply regulator binding On 9/28/23 17:45, Ben Wolsieffer wrote: > Hello, > > On Thu, Sep 28, 2023 at 05:15:08PM +0200, Christophe Roullier wrote: >> From: Christophe Roullier <christophe.roullier@...com> >> >> Configure the phy regulator if defined by the "phy-supply" DT phandle. >> >> Signed-off-by: Christophe Roullier <christophe.roullier@...s.st.com> >> --- >> .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 51 ++++++++++++++++++- >> 1 file changed, 50 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c >> index 72dda71850d75..31e3abd2caeaa 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c > ... snip ... >> static int stm32mp1_suspend(struct stm32_dwmac *dwmac) >> @@ -455,12 +496,20 @@ static int stm32mp1_suspend(struct stm32_dwmac *dwmac) >> if (dwmac->enable_eth_ck) >> clk_disable_unprepare(dwmac->clk_eth_ck); >> >> + /* Keep the PHY up if we use Wake-on-Lan. */ >> + if (!device_may_wakeup(dwmac->dev)) >> + phy_power_on(dwmac, false); >> + >> return ret; >> } >> >> static void stm32mp1_resume(struct stm32_dwmac *dwmac) >> { >> clk_disable_unprepare(dwmac->clk_ethstp); >> + >> + /* The PHY was up for Wake-on-Lan. */ >> + if (!device_may_wakeup(dwmac->dev)) >> + phy_power_on(dwmac, true); >> } >> >> static int stm32mcu_suspend(struct stm32_dwmac *dwmac) > Why only turn off the regulator in suspend on the STM32MP1 and not STM32 > MCUs? It seems like this could just go in stm32_dwmac_suspend/resume(). > > Selfishly, I have a use case for this on an STM32F746 platform, so I > would like to see support for it and would test an updated version. > Hi, I'm working on MPU boards, I do not have MCU board, so feel free to contribute on MCU part ;-) Thanks Christophe >> -- >> 2.25.1 >> > Thanks, Ben
Powered by blists - more mailing lists