lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <75435ec6-f205-1ae1-94ba-9c41fd82a045@intel.com> Date: Thu, 5 Oct 2023 15:33:06 +0200 From: Przemek Kitszel <przemyslaw.kitszel@...el.com> To: Moshe Shemesh <moshe@...dia.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org> CC: Jiri Pirko <jiri@...dia.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net v2] devlink: Hold devlink lock on health reporter dump get On 10/5/23 14:50, Moshe Shemesh wrote: > Devlink health dump get callback should take devlink lock as any other > devlink callback. Otherwise, since devlink_mutex was removed, this > callback is not protected from a race of the reporter being destroyed > while handling the callback. > > Add devlink lock to the callback and to any call for > devlink_health_do_dump(). This should be safe as non of the drivers dump > callback implementation takes devlink lock. > > As devlink lock is added to any callback of dump, the reporter dump_lock > is now redundant and can be removed. > > Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex") > Signed-off-by: Moshe Shemesh <moshe@...dia.com> > Reviewed-by: Jiri Pirko <jiri@...dia.com> > --- > v1->v2: > - Commit message, added why this fix is necessary and why its safe to do. > --- > net/devlink/health.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Powered by blists - more mailing lists