lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BL0PR11MB3122EA0512BBE5CCCF62C66BBDCAA@BL0PR11MB3122.namprd11.prod.outlook.com> Date: Thu, 5 Oct 2023 08:22:06 +0000 From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com> To: ivecera <ivecera@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "edumazet@...gle.com" <edumazet@...gle.com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "davem@...emloft.net" <davem@...emloft.net> Subject: RE: [Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular header dependencies and fix headers > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ivan Vecera > Sent: Wednesday, September 27, 2023 2:02 PM > To: netdev@...r.kernel.org > Cc: edumazet@...gle.com; intel-wired-lan@...ts.osuosl.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>; linux-kernel@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net > Subject: [Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular header dependencies and fix headers > > Similarly as for ice driver [1] there are also circular header > dependencies in i40e driver: > i40e.h -> i40e_virtchnl_pf.h -> i40e.h > > Another issue is that i40e header files does not contain their own > depenencies on other header files (both private and standard) so their > inclusion in .c file require to add these deps in certain order to > that .c file to make it compilable. > > Fix both issues by removal the mentioned circular dependency, by filling > i40e headers with their dependencies so they can be placed anywhere in > a source code. Additionally remove bunch of includes from i40e.h super > header file that are not necessary and include i40e.h only in .c files > that really require it. > > [1] 649c87c6ff52 ("ice: remove circular header dependencies on ice.h") > > Signed-off-by: Ivan Vecera <ivecera@...hat.com> > --- > drivers/net/ethernet/intel/i40e/i40e.h | 43 ++++--------------- > drivers/net/ethernet/intel/i40e/i40e_adminq.c | 4 +- > .../net/ethernet/intel/i40e/i40e_adminq_cmd.h | 2 + > drivers/net/ethernet/intel/i40e/i40e_client.c | 1 - > drivers/net/ethernet/intel/i40e/i40e_common.c | 11 +++-- > drivers/net/ethernet/intel/i40e/i40e_dcb.c | 4 +- > drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c | 2 +- > drivers/net/ethernet/intel/i40e/i40e_ddp.c | 2 +- > .../net/ethernet/intel/i40e/i40e_debugfs.c | 3 +- > drivers/net/ethernet/intel/i40e/i40e_diag.h | 5 ++- > .../net/ethernet/intel/i40e/i40e_ethtool.c | 3 +- > drivers/net/ethernet/intel/i40e/i40e_hmc.c | 3 +- > drivers/net/ethernet/intel/i40e/i40e_hmc.h | 4 ++ > .../net/ethernet/intel/i40e/i40e_lan_hmc.c | 8 ++-- > .../net/ethernet/intel/i40e/i40e_lan_hmc.h | 2 + > drivers/net/ethernet/intel/i40e/i40e_main.c | 15 ++++--- > drivers/net/ethernet/intel/i40e/i40e_nvm.c | 2 + > .../net/ethernet/intel/i40e/i40e_prototype.h | 5 +-- > drivers/net/ethernet/intel/i40e/i40e_ptp.c | 3 +- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++- > drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 + > .../ethernet/intel/i40e/i40e_txrx_common.h | 2 + > drivers/net/ethernet/intel/i40e/i40e_type.h | 7 +-- > .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 + > .../ethernet/intel/i40e/i40e_virtchnl_pf.h | 4 +- > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 -- > drivers/net/ethernet/intel/i40e/i40e_xsk.h | 4 ++ > 27 files changed, 72 insertions(+), 81 deletions(-) > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists