lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f4bcf3e9-d059-4403-a2b7-508806da9631@lunn.ch> Date: Fri, 6 Oct 2023 15:44:18 +0200 From: Andrew Lunn <andrew@...n.ch> To: Justin Lai <justinlai0215@...ltek.com> Cc: "kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Ping-Ke Shih <pkshih@...ltek.com>, Larry Chiu <larry.chiu@...ltek.com> Subject: Re: [PATCH net-next v9 08/13] net:ethernet:realtek:rtase: Implement net_device_ops > > > +static void rtase_tx_timeout(struct net_device *dev, unsigned int > > > +txqueue) { > > > + rtase_sw_reset(dev); > > > > Do you actually see this happening? The timeout is set pretty high, i think 5 > > seconds. If it does happen, it probably means you have a hardware/firmware > > bug. So you want to be noisy here, so you get to know about these problems, > > rather than silently work around them. > > I would like to ask if we can dump some information that will help > us understand the cause of the problem before doing the reset? And > should we use netdev_warn to print this information? You might want to look at 'devlink health'. Andrew
Powered by blists - more mailing lists