lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a3e8d48600984a70b23c72ce7edbc1d2@realtek.com> Date: Mon, 16 Oct 2023 01:49:53 +0000 From: Justin Lai <justinlai0215@...ltek.com> To: Andrew Lunn <andrew@...n.ch> CC: "kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Ping-Ke Shih <pkshih@...ltek.com>, Larry Chiu <larry.chiu@...ltek.com> Subject: RE: [PATCH net-next v9 08/13] net:ethernet:realtek:rtase: Implement net_device_ops > > > > > +static void rtase_tx_timeout(struct net_device *dev, unsigned int > > > > +txqueue) { > > > > + rtase_sw_reset(dev); > > > > > > Do you actually see this happening? The timeout is set pretty high, > > > i think 5 seconds. If it does happen, it probably means you have a > > > hardware/firmware bug. So you want to be noisy here, so you get to > > > know about these problems, rather than silently work around them. > > > > I would like to ask if we can dump some information that will help us > > understand the cause of the problem before doing the reset? And should > > we use netdev_warn to print this information? > > You might want to look at 'devlink health'. > > Andrew Thank you for your suggestion.
Powered by blists - more mailing lists