netdev - Re: [PATCH net-next 1/3] net: dsa: vsc73xx: add phylink capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbH-7zTdTMu2M1MesDJB7KMs1nzJqNYJWFcLuMrXoqsuQ@mail.gmail.com>
Date: Mon, 9 Oct 2023 15:04:38 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Florian Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, 
	Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 1/3] net: dsa: vsc73xx: add phylink capabilities

On Mon, Oct 9, 2023 at 12:39 PM Russell King (Oracle)
<rmk+kernel@...linux.org.uk> wrote:

> There are two different classes of switch - 5+1 and 8 port. The 5+1
> port switches uses port indicies 0-4 for the user interfaces and 6 for
> the CPU port. The 8 port is confusing - some comments in the driver
> imply that port index 7 is used, but the driver actually still uses 6,
> so that is what we go with. Also, there appear to be no DTs in the
> kernel tree that are using the 8 port variety.

This has never been tested, I think the 8 port variant is mostly
used in stand-alone configurations without a CPU, the first user
of a Linux setup will have to deal with it if the need arise.

The patch looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij