netdev - Re: [PATCH net] net: nfc: fix races in nfc_llcp_sock_get() and nfc_llcp_sock_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a28ef00-f498-4fa0-bc2b-10a460e1a88c@linaro.org>
Date: Mon, 9 Oct 2023 15:08:58 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Sili Luo <rootlab@...wei.com>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH net] net: nfc: fix races in nfc_llcp_sock_get() and
 nfc_llcp_sock_get_sn()

On 09/10/2023 14:31, Eric Dumazet wrote:
> Sili Luo reported a race in nfc_llcp_sock_get(), leading to UAF.
> 
> Getting a reference on the socket found in a lookup while
> holding a lock should happen before releasing the lock.
> 
> nfc_llcp_sock_get_sn() has a similar problem.
> 
> Finally nfc_llcp_recv_snl() needs to make sure the socket
> found by nfc_llcp_sock_from_sn() does not disappear.
> 
> Fixes: 8f50020ed9b8 ("NFC: LLCP late binding")
> Reported-by: Sili Luo <rootlab@...wei.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Cc: Willy Tarreau <w@....eu>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof