netdev - Re: [REGRESSION] Userland interface breaks due to hard HFSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da08ba06-e24c-d2c3-b9a0-8415a83ae791@mojatatu.com>
Date: Mon, 9 Oct 2023 12:31:57 -0300
From: Pedro Tammela <pctammela@...atatu.com>
To: Jakub Kicinski <kuba@...nel.org>, markovicbudimir@...il.com
Cc: Christian Theune <ct@...ingcircus.io>, stable@...r.kernel.org,
 netdev@...r.kernel.org,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [REGRESSION] Userland interface breaks due to hard HFSC_FSC
 requirement

On 09/10/2023 12:06, Jakub Kicinski wrote:
> On Sat, 7 Oct 2023 06:10:42 +0200 Christian Theune wrote:
>> The idea of not bricking your system by upgrading the Linux kernel
>> seems to apply here. IMHO the change could maybe done in a way that
>> keeps the system running but informs the user that something isn’t
>> working as intended?
> 
> Herm, how did we get this far without CCing the author of the patch.
> Adding Budimir.
> 
> Pedro, Budimir, any idea what the original bug was? There isn't much
> info in the commit message.

We had a UAF with a very straight forward way to trigger it.
Setting 'rt' as a parent is incorrect and the man page is explicit about 
it as it doesn't make sense 'qdisc wise'. Being able to set it has 
always been wrong unfortunately...