netdev - Re: [PATCH net] bonding: Return pointer to data after pull on skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28783.1696963547@famine>
Date: Tue, 10 Oct 2023 11:45:47 -0700
From: Jay Vosburgh <jay.vosburgh@...onical.com>
To: Jiri Wiesner <jwiesner@...e.de>
cc: netdev@...r.kernel.org, Moshe Tal <moshet@...dia.com>,
    Jussi Maki <joamaki@...il.com>, Andy Gospodarek <andy@...yhouse.net>,
    "David
 S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] bonding: Return pointer to data after pull on skb

Jiri Wiesner <jwiesner@...e.de> wrote:

>Since 429e3d123d9a ("bonding: Fix extraction of ports from the packet
>headers"), header offsets used to compute a hash in bond_xmit_hash() are
>relative to skb->data and not skb->head. If the tail of the header buffer
>of an skb really needs to be advanced and the operation is successful, the
>pointer to the data must be returned (and not a pointer to the head of the
>buffer).

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

>Fixes: 429e3d123d9a ("bonding: Fix extraction of ports from the packet headers")
>Signed-off-by: Jiri Wiesner <jwiesner@...e.de>
>---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index ed7212e61c54..51d47eda1c87 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -4023,7 +4023,7 @@ static inline const void *bond_pull_data(struct sk_buff *skb,
> 	if (likely(n <= hlen))
> 		return data;
> 	else if (skb && likely(pskb_may_pull(skb, n)))
>-		return skb->head;
>+		return skb->data;
> 
> 	return NULL;
> }
>-- 
>2.35.3
>
>
>-- 
>Jiri Wiesner
>SUSE Labs
>