netdev - Re: [PATCH net] bonding: Return pointer to data after pull on skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSbKWoCUbL8HR7Ar@nanopsycho>
Date: Wed, 11 Oct 2023 18:16:26 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jiri Wiesner <jwiesner@...e.de>
Cc: netdev@...r.kernel.org, Moshe Tal <moshet@...dia.com>,
	Jussi Maki <joamaki@...il.com>, Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] bonding: Return pointer to data after pull on skb

Tue, Oct 10, 2023 at 06:39:33PM CEST, jwiesner@...e.de wrote:
>Since 429e3d123d9a ("bonding: Fix extraction of ports from the packet
>headers"), header offsets used to compute a hash in bond_xmit_hash() are
>relative to skb->data and not skb->head. If the tail of the header buffer
>of an skb really needs to be advanced and the operation is successful, the
>pointer to the data must be returned (and not a pointer to the head of the
>buffer).
>
>Fixes: 429e3d123d9a ("bonding: Fix extraction of ports from the packet headers")
>Signed-off-by: Jiri Wiesner <jwiesner@...e.de>

Reviewed-by: Jiri Pirko <jiri@...dia.com>