netdev - Re: [PATCH 09/10] wireless: hostap: remove unused ioctl function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <08cfd4d6-d12f-4e63-8f87-12cda83fa7b3@app.fastmail.com>
Date: Wed, 11 Oct 2023 15:58:27 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Kalle Valo" <kvalo@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Jakub Kicinski" <kuba@...nel.org>, Netdev <netdev@...r.kernel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-wireless@...r.kernel.org, "Johannes Berg" <johannes@...solutions.net>,
 linux-wpan@...r.kernel.org,
 "Michael Hennerich" <michael.hennerich@...log.com>,
 "Paolo Abeni" <pabeni@...hat.com>, "Eric Dumazet" <edumazet@...gle.com>,
 "David S . Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org,
 "Doug Brown" <doug@...morgal.com>
Subject: Re: [PATCH 09/10] wireless: hostap: remove unused ioctl function

On Tue, Oct 10, 2023, at 09:00, Kalle Valo wrote:
> Arnd Bergmann <arnd@...nel.org> writes:
>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The ioctl handler has no actual callers in the kernel and is useless.
>> All the functionality should be reachable through the regualar interfaces.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> In the title we prefer "wifi:" over "wireless:" but that's nitpicking. I
> assume this goes via a net tree so:

Changed for v2

> Acked-by: Kalle Valo <kvalo@...nel.org>

Thanks

> Let me know if I should take this to wireless-next instead.

I think it's better to keep the series together and merge it
through net-next directly, since the last patch depends on all
the ones before it.

     Arnd