lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4d7c2ab9-e980-42a5-9452-79bc0d33e094@lunn.ch> Date: Wed, 11 Oct 2023 14:41:26 +0200 From: Andrew Lunn <andrew@...n.ch> To: MD Danish Anwar <danishanwar@...com> Cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, srk@...com, Vignesh Raghavendra <vigneshr@...com>, r-gunasekaran@...com, Roger Quadros <rogerq@...nel.org> Subject: Re: [PATCH] net: ti: icssg-prueth: Fix tx_total_bytes count > @@ -29,7 +30,12 @@ void emac_update_hardware_stats(struct prueth_emac *emac) > base + icssg_all_stats[i].offset, > val); > > + if (!strncmp(icssg_ethtool_stats[i].name, "tx_good_frames", ETH_GSTRING_LEN)) > + tx_pkt_cnt = val; Doing a strncmp seems very expensive. Could you make use of icssg_stats.offset? Andrew
Powered by blists - more mailing lists