netdev - Re: [PATCH 1/2] net: ethernet: davinci_emac: Use MAC Address from Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 11 Oct 2023 07:53:55 -0500
From: Adam Ford <aford173@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: linux-omap@...r.kernel.org, aford@...conembedded.com, 
	Benoît Cousson <bcousson@...libre.com>, 
	Tony Lindgren <tony@...mide.com>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Grygorii Strashko <grygorii.strashko@...com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: davinci_emac: Use MAC Address from
 Device Tree

On Wed, Sep 6, 2023 at 7:39 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Sep 06, 2023 at 04:51:42AM -0500, Adam Ford wrote:
> > Currently there is a device tree entry called "local-mac-address"
> > which can be filled by the bootloader or manually set.This is
> > useful when the user does not want to use the MAC address
> > programmed into the SoC.
> >
> > Currently, the davinci_emac reads the MAC from the DT, copies
> > it from pdata->mac_addr to priv->mac_addr, then blindly overwrites
> > it by reading from registers in the SoC, and falls back to a
> > random MAC if it's still not valid.  This completely ignores any
> > MAC address in the device tree.
> >
> > In order to use the local-mac-address, check to see if the contents
> > of priv->mac_addr are valid before falling back to reading from the
> > SoC when the MAC address is not valid.
> >
> > Signed-off-by: Adam Ford <aford173@...il.com>
>
> There is the potential for regressions here, since behaviour is being
> changed. But i do think what you are doing make sense.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

I don't know who the right person is to ask, but is there any chance
this can be accepted?

adam
>
>     Andrew