netdev - Re: [PATCH net-next] mlxsw: pci: Allocate skbs using GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSa5zFyFdU4njwj4@nanopsycho>
Date: Wed, 11 Oct 2023 17:05:48 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	mlxsw@...dia.com
Subject: Re: [PATCH net-next] mlxsw: pci: Allocate skbs using GFP_KERNEL
 during initialization

Wed, Oct 11, 2023 at 04:39:12PM CEST, petrm@...dia.com wrote:
>From: Ido Schimmel <idosch@...dia.com>
>
>The driver allocates skbs during initialization and during Rx
>processing. Take advantage of the fact that the former happens in
>process context and allocate the skbs using GFP_KERNEL to decrease the
>probability of allocation failure.
>
>Tested with CONFIG_DEBUG_ATOMIC_SLEEP=y.
>
>Signed-off-by: Ido Schimmel <idosch@...dia.com>
>Reviewed-by: Petr Machata <petrm@...dia.com>
>Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>