netdev - Re: [PATCH v2 net] nfc: nci: assert requested protocol is valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSbBS74m2PmdSmP2@kernel.org>
Date: Wed, 11 Oct 2023 17:37:47 +0200
From: Simon Horman <horms@...nel.org>
To: Jeremy Cline <jeremy@...ine.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Dmitry Vyukov <dvyukov@...gle.com>, Lin Ma <linma@....edu.cn>,
	Ilan Elias <ilane@...com>,
	"John W . Linville" <linville@...driver.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzbot+0839b78e119aae1fec78@...kaller.appspotmail.com
Subject: Re: [PATCH v2 net] nfc: nci: assert requested protocol is valid

On Mon, Oct 09, 2023 at 04:00:54PM -0400, Jeremy Cline wrote:
> The protocol is used in a bit mask to determine if the protocol is
> supported. Assert the provided protocol is less than the maximum
> defined so it doesn't potentially perform a shift-out-of-bounds and
> provide a clearer error for undefined protocols vs unsupported ones.
> 
> Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
> Reported-and-tested-by: syzbot+0839b78e119aae1fec78@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=0839b78e119aae1fec78
> Signed-off-by: Jeremy Cline <jeremy@...ine.org>

As per my review of v1, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>