netdev - Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb626b3e-21f5-4548-8674-3bf049e6cf9a@intel.com>
Date: Fri, 13 Oct 2023 17:27:12 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: MD Danish Anwar <danishanwar@...com>, Andrew Lunn <andrew@...n.ch>, "Arnd
 Bergmann" <arnd@...db.de>, Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Simon Horman <horms@...nel.org>, Roger Quadros <rogerq@...com>, "Vignesh
 Raghavendra" <vigneshr@...com>, Paolo Abeni <pabeni@...hat.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S.
 Miller" <davem@...emloft.net>
CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <srk@...com>,
	<r-gunasekaran@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object

From: Md Danish Anwar <danishanwar@...com>
Date: Fri, 13 Oct 2023 15:35:49 +0530

> With CONFIG_TI_K3_AM65_CPSW_NUSS=y and CONFIG_TI_ICSSG_PRUETH=m,
> k3-cppi-desc-pool.o is linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> The build system is complaining about the following:
> 
> k3-cppi-desc-pool.o is added to multiple modules: icssg-prueth
> ti-am65-cpsw-nuss

I also fixed a bunch of these in the ethernet/ti/ folder a year ago[0],
you can take a look. I never made it to the upstream branches since I
took a rest from my home Linux projects and never got back to them yet :P

> 
> Introduce the new module, k3-cppi-desc-pool, to provide the common
> functions to ti-am65-cpsw-nuss and icssg-prueth.

[...]

[0] https://lore.kernel.org/all/20221119225650.1044591-19-alobakin@pm.me

Thanks,
Olek