netdev - Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ff6c4489-7816-4fe2-b6da-53c5d3a24331@app.fastmail.com>
Date: Tue, 17 Oct 2023 13:38:07 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "MD Danish Anwar" <danishanwar@...com>, "Andrew Lunn" <andrew@...n.ch>,
 "Wolfram Sang" <wsa+renesas@...g-engineering.com>,
 "Simon Horman" <horms@...nel.org>, "Roger Quadros" <rogerq@...com>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "Eric Dumazet" <edumazet@...gle.com>,
 "David S . Miller" <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org, Netdev <netdev@...r.kernel.org>, srk@...com,
 r-gunasekaran@...com, "Roger Quadros" <rogerq@...nel.org>
Subject: Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object

On Fri, Oct 13, 2023, at 13:10, MD Danish Anwar wrote:
> On 13/10/23 16:08, Arnd Bergmann wrote:
>> On Fri, Oct 13, 2023, at 12:05, MD Danish Anwar wrote:
>>> With CONFIG_TI_K3_AM65_CPSW_NUSS=y and CONFIG_TI_ICSSG_PRUETH=m,
>>> k3-cppi-desc-pool.o is linked to a module and also to vmlinux even though
>>> the expected CFLAGS are different between builtins and modules.
>>>
>>> The build system is complaining about the following:
>>>
>>> k3-cppi-desc-pool.o is added to multiple modules: icssg-prueth
>>> ti-am65-cpsw-nuss
>>>
>>> Introduce the new module, k3-cppi-desc-pool, to provide the common
>>> functions to ti-am65-cpsw-nuss and icssg-prueth.
>>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
>> 
>> I submitted a different patch for this a while ago:
>> https://lore.kernel.org/lkml/20230612124024.520720-3-arnd@kernel.org/
>> 
>> I think I never sent a v2 of that, but I still have a
>> working version in my local tree. I've replaced my version
>> with yours for testing now, to see if you still need something
>> beyond that.
>> 
>
> I see your patch addresses different modules. My patch introduces a new
> module for k3-cppi-desc-pool which is used by both am65-cpsw-nuss and
> icssg-prueth driver. Where as your patch addresses modules common across
> different cpsw drivers (davinci-emac, cpsw, cpsw-switchdev, netcp,
> netcp_ethss and am65-cpsw-nuss). So I think that both these patches are
> addressing differet warnings.

Right, I can resend my patch (or Alexander Lobakin can rebase his version)
after yours makes it in. Note that your patch introduces a warning about
a missing license and description for the new module, so you should
probably include this hunk:

--- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
+++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
@@ -131,3 +131,6 @@ size_t k3_cppi_desc_pool_avail(struct k3_cppi_desc_pool *pool)
        return gen_pool_avail(pool->gen_pool) / pool->desc_size;
 }
 EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_avail);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("TI K3 CPPI5 descriptors pool API");