netdev - Re: [PATCH v7 net-next 00/18] Introducing P4TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 17 Oct 2023 11:27:36 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, anjali.singhai@...el.com, namrata.limaye@...el.com, 
	deb.chatterjee@...el.com, john.andy.fingerhut@...el.com, dan.daly@...el.com, 
	Vipin.Jain@....com, tom@...anda.io, mleitner@...hat.com, 
	Mahesh.Shirshyad@....com, tomasz.osinski@...el.com, jiri@...nulli.us, 
	xiyou.wangcong@...il.com, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, vladbu@...dia.com, horms@...nel.org, khalidm@...dia.com, 
	toke@...hat.com, mattyk@...dia.com
Subject: Re: [PATCH v7 net-next 00/18] Introducing P4TC

On Mon, Oct 16, 2023 at 6:35 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 16 Oct 2023 17:44:20 -0400 Jamal Hadi Salim wrote:
> > > Verified from downloading mbox.gz from lore that the tarball was
> > > reordered. Dont know if it contributed - but now compiling patch by
> > > patch on the latest net-next tip.
> >
> > Never mind - someone pointed me to patch work and i can see some
> > warnings there. Looks like we need more build types and compiler
> > options to catch some of these issues.
> > We'll look into it and we will replicate in our cicd.
>
> patch-by-patch W=1 C=1 should be good enough to catch the problems.

Thanks - this helps. We didnt pay good attention to
https://www.kernel.org/doc/Documentation/process/maintainer-netdev.rst
Only thing that is missing now is the mention of C=1 in the doc. Patch
to the doc acceptable?
Also a note about false positives in sparse output (there were a few
in the warnings from the bot) would be apropos.

cheers,
jamal