netdev - Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b6b347d-ff28-4c4d-9eae-d0d9a83d572a@gmail.com>
Date: Tue, 17 Oct 2023 13:37:53 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Simon Horman <horms@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>
Cc: netdev@...r.kernek.org, Justin Chen <justin.chen@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 "open list:BROADCOM ETHERNET PHY DRIVERS" <netdev@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics

On 10/17/23 12:45, Simon Horman wrote:
> On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
>> The .probe() function would allocate the necessary space and ensure that
>> the library call sizes the nunber of statistics but the callbacks
>> necessary to fetch the name and values were not wired up.
>>
>> Reported-by: Justin Chen <justin.chen@...adcom.com>
>> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> 
> Should the fixes tag be as follows?
> 
> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")

Yes it should, it looks like 1b89b3dce34c was from our downstream tree. 
Let me re-submit with the correct Fixes tag then, thanks Simon!
-- 
Florian