netdev - Re: [PATCH net-next v4 2/5] ice: configure FW logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d054523-f724-1c49-a942-0a51f413c3a6@intel.com>
Date: Tue, 17 Oct 2023 13:38:52 -0700
From: Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<jacob.e.keller@...el.com>, <vaishnavi.tipireddy@...el.com>,
	<horms@...nel.org>, <leon@...nel.org>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next v4 2/5] ice: configure FW logging

On 10/12/2023 4:40 PM, Jakub Kicinski wrote:
> On Wed, 11 Oct 2023 17:40:04 -0700 Paul M Stillwell Jr wrote:
>> OK, so what if we changed the code to create a new debugfs file entry
>> for each module and used the dentry for ther file to know what file is
>> being written to. Then we would only need to parse the log level. Would
>> that be acceptable?
> 
> Yes, even better!
> 

Cool, I'll work on this along with the other changes we discussed.

>> My confusion is around what makes the cmdline parsing harder to follow.
>> Obviously for me it's easy :) so I am trying to understand your point of
>> view.
> 
> Dunno how to explain it other than "took me more than 10min to
> understand this code and I only had 10min" :)  Reviewers have
> their own angle when evaluation code which doesn't always align
> with the author's..

No problem, I appreciate your feedback. Hopefully the new patches are 
easier to follow. I'll also try to keep your 10 minute rule in mind :)