lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231017062535.GC3539182@pengutronix.de> Date: Tue, 17 Oct 2023 08:25:35 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Andrew Lunn <andrew@...n.ch> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>, Woojung Huh <woojung.huh@...rochip.com>, Arun Ramadoss <arun.ramadoss@...rochip.com>, Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com, "Russell King (Oracle)" <linux@...linux.org.uk>, devicetree@...r.kernel.org Subject: Re: [PATCH net-next v4 4/9] net: dsa: microchip: ksz9477: add Wake on LAN support On Mon, Oct 16, 2023 at 04:59:24PM +0200, Andrew Lunn wrote: > > +int ksz9477_set_wol(struct ksz_device *dev, int port, > > + struct ethtool_wolinfo *wol) > > +{ > > + u8 pme_conf, pme_ctrl = 0; > > + int ret; > > + > > + if (wol->wolopts & ~WAKE_PHY) > > + return -EINVAL; > > EOPNOTSUPP might be better here. I'm assuming there is no other way > WoL can be supported, since this is a combined MAC/PHY device. EOPNOTSUPP is typically returned when WoL isn’t supported at all. In this instance, WoL is supported but an invalid option has been given. Nonetheless, I don’t have a strong opinion on this matter currently, and am ready to go with whichever option is recommended. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists