lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aa78dff4-d572-4abc-9f86-3c01f887faf1@kadam.mountain> Date: Thu, 19 Oct 2023 13:34:49 +0300 From: Dan Carpenter <dan.carpenter@...aro.org> To: Su Hui <suhui@...china.com> Cc: woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com, netdev@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] net: lan78xx: add an error code check in lan78xx_write_raw_eeprom On Thu, Oct 19, 2023 at 04:40:23PM +0800, Su Hui wrote: > check the value of 'ret' after call 'lan78xx_read_reg'. > > Signed-off-by: Su Hui <suhui@...china.com> > --- > > Clang complains that value stored to 'ret' is never read. > Maybe this place miss an error code check, I'm not sure > about this. There are a bunch more "ret = " assignments which aren't used in this function. regards, dan carpenter
Powered by blists - more mailing lists