lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231019084022.1528885-1-suhui@nfschina.com> Date: Thu, 19 Oct 2023 16:40:23 +0800 From: Su Hui <suhui@...china.com> To: woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com Cc: Su Hui <suhui@...china.com>, netdev@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, kernel-janitors@...r.kernel.org Subject: [PATCH] net: lan78xx: add an error code check in lan78xx_write_raw_eeprom check the value of 'ret' after call 'lan78xx_read_reg'. Signed-off-by: Su Hui <suhui@...china.com> --- Clang complains that value stored to 'ret' is never read. Maybe this place miss an error code check, I'm not sure about this. drivers/net/usb/lan78xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 59cde06aa7f6..347788336b11 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -977,6 +977,10 @@ static int lan78xx_write_raw_eeprom(struct lan78xx_net *dev, u32 offset, * disable & restore LED function to access EEPROM. */ ret = lan78xx_read_reg(dev, HW_CFG, &val); + if (ret < 0) { + retval = -EIO; + goto exit; + } saved = val; if (dev->chipid == ID_REV_CHIP_ID_7800_) { val &= ~(HW_CFG_LED1_EN_ | HW_CFG_LED0_EN_); -- 2.30.2
Powered by blists - more mailing lists