netdev - Re: [PATCH net-next] iavf: delete unused iavf_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cda1cc98-7c0e-4712-830a-9ba0bfeb951c@redhat.com>
Date: Thu, 19 Oct 2023 18:34:00 +0200
From: Ivan Vecera <ivecera@...hat.com>
To: Michal Schmidt <mschmidt@...hat.com>,
 "Drewek, Wojciech" <wojciech.drewek@...el.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
 "Keller, Jacob E" <jacob.e.keller@...el.com>,
 "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
 "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] iavf: delete unused iavf_mac_info fields



On 18. 10. 23 17:11, Michal Schmidt wrote:
> On Wed, Oct 18, 2023 at 1:26 PM Drewek, Wojciech
> <wojciech.drewek@...el.com>  wrote:
>>> -----Original Message-----
>>> From: Michal Schmidt<mschmidt@...hat.com>
>>> Sent: Wednesday, October 18, 2023 1:15 PM
>>> To:intel-wired-lan@...ts.osuosl.org
>>> Cc: Keller, Jacob E<jacob.e.keller@...el.com>; Drewek, Wojciech
>>> <wojciech.drewek@...el.com>; Brandeburg, Jesse
>>> <jesse.brandeburg@...el.com>; Nguyen, Anthony L
>>> <anthony.l.nguyen@...el.com>;netdev@...r.kernel.org
>>> Subject: [PATCH net-next] iavf: delete unused iavf_mac_info fields
>>>
>>> 'san_addr' and 'mac_fcoeq' members of struct iavf_mac_info are unused.
>>> 'type' is write-only. Delete all three.
>>>
>>> The function iavf_set_mac_type that sets 'type' also checks if the PCI
>>> vendor ID is Intel. This is unnecessary. Delete the whole function.
>>>
>>> If in the future there's a need for the MAC type (or other PCI
>>> ID-dependent data), I would prefer to use .driver_data in iavf_pci_tbl[]
>>> for this purpose.
>>>
>>> Signed-off-by: Michal Schmidt<mschmidt@...hat.com>
>> Reviewed-by: Wojciech Drewek<wojciech.drewek@...el.com>
>>
>> Nice cleanup, I've seen similar unused fields in i40e as well.
>> Any plans for i40e cleanup?
> No, I am not planning to look into i40e cleanups in the near future.
> Ivan might want to do that though. [Adding him to the thread]
> Michal

OK, I will do it...

Thanks,
Ivan