netdev - Re: [EXT] Re: [net-next PATCH v3] octeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231019125107.5acd7c1e@kernel.org>
Date: Thu, 19 Oct 2023 12:51:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: "horms@...nel.org" <horms@...nel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "egallen@...hat.com" <egallen@...hat.com>, Haseeb
 Gani <hgani@...vell.com>, "mschmidt@...hat.com" <mschmidt@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Sathesh B Edara
 <sedara@...vell.com>, Veerasenareddy Burru <vburru@...vell.com>, Vimlesh
 Kumar <vimleshk@...vell.com>
Subject: Re: [EXT] Re: [net-next PATCH v3] octeon_ep: pack hardware
 structure

On Thu, 19 Oct 2023 18:46:09 +0000 Shinas Rasheed wrote:
> Since these structures represent how hardware expects data, there can
> be a lack of alignment.

Doesn't the host allocate at least most of those?
Therefore controlling the alignment?

> I'm afraid static asserting all the hardware data structures might
> force some compilers to fail?

C has structure packing rules which mean that in 99.9999% of the cases
none of your structs need explicit packing. For the 0.0001% of arches
breaking build is fine.

At least that's my guess, again, I wasn't the one who rejected the
patch. I just noticed it was dropped in patchwork and made a guess
based on past experience.