netdev - Re: [PATCH iproute2-next 2/2] bpf: increase verifier verbosity when in verbose mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 19 Oct 2023 13:44:34 -0600
From: David Ahern <dsahern@...nel.org>
To: Shung-Hsi Yu <shung-hsi.yu@...e.com>
Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>,
 Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH iproute2-next 2/2] bpf: increase verifier verbosity when
 in verbose mode

On 10/18/23 7:18 PM, Shung-Hsi Yu wrote:
> Ah, good point. I was trying to separate out libbpf-related changes from
> verbosity-increasing changes, hence the first patch. And there I add the
> .kernel_log_level field within DECLARE_LIBBPF_OPTS() because that seems to
> be how it's usually done.
> 
> In the second patch I tried to make log-level changes consistent, having
> them all done with `|= 2`, which isn't possible within
> DECLARE_LIBBPF_OPTS().
> 
> Maybe I should have just have `open_opts.kernel_log_level = 1;` outside of
> DECLARE_LIBBPF_OPTS() in the first patch to begin with.
> 
> +#if (LIBBPF_MAJOR_VERSION > 0) || (LIBBPF_MINOR_VERSION >= 7)
> +	open_opts.kernel_log_level = 1;
> +#endif
> 
> Followed by
> 
>  #if (LIBBPF_MAJOR_VERSION > 0) || (LIBBPF_MINOR_VERSION >= 7)
>  	open_opts.kernel_log_level = 1;
> +	if (cfg->verbose)
> +		open_opts.kernel_log_level |= 2;
>  #endif
> 

that is less confusing for a patch sequence.