netdev - Re: [net-next PATCH v5 03/10] ice: Add support in the driver for associating queue with napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 19 Oct 2023 13:18:26 +0800
From: kernel test robot <lkp@...el.com>
To: Amritha Nambiar <amritha.nambiar@...el.com>, netdev@...r.kernel.org,
	kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, sridhar.samudrala@...el.com,
	amritha.nambiar@...el.com
Subject: Re: [net-next PATCH v5 03/10] ice: Add support in the driver for
 associating queue with napi

Hi Amritha,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Amritha-Nambiar/netdev-genl-spec-Extend-netdev-netlink-spec-in-YAML-for-queue/20231019-082941
base:   net-next/main
patch link:    https://lore.kernel.org/r/169767397753.6692.15797121214738496388.stgit%40anambiarhost.jf.intel.com
patch subject: [net-next PATCH v5 03/10] ice: Add support in the driver for associating queue with napi
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231019/202310191339.JfORBqdK-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/202310191339.JfORBqdK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310191339.JfORBqdK-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/ice/ice_lib.c:2943:6: warning: no previous prototype for 'ice_queue_set_napi' [-Wmissing-prototypes]
    2943 | void ice_queue_set_napi(unsigned int queue_index, enum netdev_queue_type type,
         |      ^~~~~~~~~~~~~~~~~~


vim +/ice_queue_set_napi +2943 drivers/net/ethernet/intel/ice/ice_lib.c

  2933	
  2934	/**
  2935	 * ice_queue_set_napi - Set the napi instance for the queue
  2936	 * @queue_index: Index of queue
  2937	 * @type: queue type as RX or TX
  2938	 * @napi: NAPI context
  2939	 * @locked: is the rtnl_lock already held
  2940	 *
  2941	 * Set the napi instance for the queue
  2942	 */
> 2943	void ice_queue_set_napi(unsigned int queue_index, enum netdev_queue_type type,
  2944				struct napi_struct *napi, bool locked)
  2945	{
  2946		if (locked)
  2947			__netif_queue_set_napi(queue_index, type, napi);
  2948		else
  2949			netif_queue_set_napi(queue_index, type, napi);
  2950	}
  2951	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki