lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231020100709.yy2ovjm3q2hphek6@skbuf> Date: Fri, 20 Oct 2023 13:07:09 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Su Hui <suhui@...china.com> Cc: andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: add an error code check in mv88e6352_tai_event_work On Fri, Oct 20, 2023 at 05:00:04PM +0800, Su Hui wrote: > mv88e6xxx_tai_write() can return error code (-EOPNOTSUPP ...) if failed. > So check the value of 'ret' after calling mv88e6xxx_tai_write(). > > Signed-off-by: Su Hui <suhui@...china.com> > --- mv88e6xxx_avb_ops :: tai_read() and tai_write() come in pairs for the existing implementations. So, a missing tai_write() method also implies a missing tai_read() and would have been caught by the previous call to mv88e6xxx_tai_read() in this function. But, ok. Reviewed-by: Vladimir Oltean <vladimir.oltean@....com> This is a patch for net-next, as it doesn't fix any user-visible issue and is just an improvement. For future changes, please note your expectation regarding the target tree yourself, by formatting the patch as "[PATCH net-next]".
Powered by blists - more mailing lists