netdev - Re: [PATCH net-next 1/6] net: don't use input buffer of __dev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTJTKN5wzf4lWRfk@nanopsycho>
Date: Fri, 20 Oct 2023 12:15:04 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, johannes.berg@...el.com, mpe@...erman.id.au,
	j@...fi
Subject: Re: [PATCH net-next 1/6] net: don't use input buffer of
 __dev_alloc_name() as a scratch space

Fri, Oct 20, 2023 at 03:18:51AM CEST, kuba@...nel.org wrote:
>Callers of __dev_alloc_name() want to pass dev->name as
>the output buffer. Make __dev_alloc_name() not clobber
>that buffer on failure, and remove the workarounds
>in callers.
>
>dev_alloc_name_ns() is now completely unnecessary.
>
>The extra strscpy() added here will be gone by the end
>of the patch series.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>