netdev - Re: [PATCH net-next] net_sched: sch_fq: fix off-by-one error in fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 20 Oct 2023 16:31:29 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, 
 eric.dumazet@...il.com, 
 Eric Dumazet <edumazet@...gle.com>, 
 kernel test robot <oliver.sang@...el.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Soheil Hassas Yeganeh <soheil@...gle.com>, 
 Dave Taht <dave.taht@...il.com>, 
 Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH net-next] net_sched: sch_fq: fix off-by-one error in
 fq_dequeue()

Eric Dumazet wrote:
> A last minute change went wrong.
> 
> We need to look for a packet in all 3 bands, not only two.
> 
> Fixes: 29f834aa326e ("net_sched: sch_fq: add 3 bands and WRR scheduling")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202310201422.a22b0999-oliver.sang@intel.com
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
> Cc: Dave Taht <dave.taht@...il.com>
> Cc: Toke Høiland-Jørgensen <toke@...hat.com>

Tested-by: Willem de Bruijn <willemb@...gle.com>