lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BL0PR11MB31226A0095D6A906D12C6C31BDDBA@BL0PR11MB3122.namprd11.prod.outlook.com> Date: Fri, 20 Oct 2023 05:44:11 +0000 From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com> To: ivecera <ivecera@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: Przemyslaw Patynowski <przemyslawx.patynowski@...el.com>, "Palczewski, Mateusz" <mateusz.palczewski@...el.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, open list <linux-kernel@...r.kernel.org>, "Eric Dumazet" <edumazet@...gle.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>, "Sylwester Dziedziuch" <sylwesterx.dziedziuch@...el.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, "moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org> Subject: RE: [Intel-wired-lan] [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ivan Vecera > Sent: Thursday, October 19, 2023 10:07 PM > To: netdev@...r.kernel.org > Cc: Przemyslaw Patynowski <przemyslawx.patynowski@...el.com>; Palczewski, Mateusz <mateusz.palczewski@...el.com>; Brandeburg, Jesse <jesse.brandeburg@...el.com>; open list <linux-kernel@...r.kernel.org>; Eric Dumazet <edumazet@...gle.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Sylwester Dziedziuch <sylwesterx.dziedziuch@...el.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>; moderated list:INTEL ETHERNET DRIVERS <intel-wired-lan@...ts.osuosl.org> > Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value > > Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new > PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with > existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag. > > Move the affected flag at the end of the flags and fix its value. > > Reproducer: > [root@...-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close on > [root@...-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning on > [root@...-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off > [ 6323.142585] i40e 0000:02:00.0: Setting link-down-on-close not supported on this port (because total-port-shutdown is enabled) > netlink error: Operation not supported > [root@...-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning off > [root@...-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off > > The link-down-on-close flag cannot be modified after setting vf-vlan-pruning > because vf-vlan-pruning shares the same bit with total-port-shutdown flag > that prevents any modification of link-down-on-close flag. > > Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning") > Cc: Mateusz Palczewski <mateusz.palczewski@...el.com> > Cc: Simon Horman <horms@...nel.org> > Signed-off-by: Ivan Vecera <ivecera@...hat.com> > --- > drivers/net/ethernet/intel/i40e/i40e.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists