netdev - Re: [net-next PATCH v5 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 20 Oct 2023 17:37:46 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <oe-kbuild-all@...ts.linux.dev>
CC: kernel test robot <lkp@...el.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [net-next PATCH v5 01/10] netdev-genl: spec: Extend netdev
 netlink spec in YAML for queue

On 10/20/2023 3:05 PM, Jakub Kicinski wrote:
> On Fri, 20 Oct 2023 13:26:38 -0700 Nambiar, Amritha wrote:
>>> WARNING:SPACING: space prohibited between function name and open parenthesis '('
>>> #547: FILE: tools/net/ynl/generated/netdev-user.h:181:
>>> +	struct netdev_queue_get_rsp obj __attribute__ ((aligned (8)));
>>
>> Looks like the series is in "Changes Requested" state following these
>> warnings. Is there any recommendation for warnings on generated code? I
>> see similar issues on existing code in the generated file.
> 
> Yes, ignore this one. I'll post a change to the codegen.
> The warning on patch 3 is legit, right?
> 

Thanks for the fix to codegen.
Yes, the warning on patch 3 is legit. I'll fix it up in the next version 
together with addressing other review feedback on this v5 series.

> kernel test bot folks, please be careful with the checkpatch warnings.
> Some of them are bogus. TBH I'm not sure how much value running
> checkpatch in the bot adds. It's really trivial to run for the
> maintainers when applying patches.
>