| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231021.192741.2305009064677924338.fujita.tomonori@gmail.com>
Date: Sat, 21 Oct 2023 19:27:41 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: benno.lossin@...ton.me
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
rust-for-linux@...r.kernel.org, andrew@...n.ch,
miguel.ojeda.sandonis@...il.com, tmgross@...ch.edu, boqun.feng@...il.com,
wedsonaf@...il.com, greg@...ah.com
Subject: Re: [PATCH net-next v5 1/5] rust: core abstractions for network
PHY drivers
On Sat, 21 Oct 2023 08:37:08 +0000
Benno Lossin <benno.lossin@...ton.me> wrote:
> On 21.10.23 09:30, FUJITA Tomonori wrote:
>> On Sat, 21 Oct 2023 07:25:17 +0000
>> Benno Lossin <benno.lossin@...ton.me> wrote:
>>
>>> On 20.10.23 14:54, FUJITA Tomonori wrote:
>>>> On Fri, 20 Oct 2023 09:34:46 +0900 (JST)
>>>> FUJITA Tomonori <fujita.tomonori@...il.com> wrote:
>>>>
>>>>> On Thu, 19 Oct 2023 15:20:51 +0000
>>>>> Benno Lossin <benno.lossin@...ton.me> wrote:
>>>>>
>>>>>> I would like to remove the mutable static variable and simplify
>>>>>> the macro.
>>>>>
>>>>> How about adding DriverVTable array to Registration?
>>>>>
>>>>> /// Registration structure for a PHY driver.
>>>>> ///
>>>>> /// # Invariants
>>>>> ///
>>>>> /// The `drivers` slice are currently registered to the kernel via `phy_drivers_register`.
>>>>> pub struct Registration<const N: usize> {
>>>>> drivers: [DriverVTable; N],
>>>>> }
>>>>>
>>>>> impl<const N: usize> Registration<{ N }> {
>>>>> /// Registers a PHY driver.
>>>>> pub fn register(
>>>>> module: &'static crate::ThisModule,
>>>>> drivers: [DriverVTable; N],
>>>>> ) -> Result<Self> {
>>>>> let mut reg = Registration { drivers };
>>>>> let ptr = reg.drivers.as_mut_ptr().cast::<bindings::phy_driver>();
>>>>> // SAFETY: The type invariants of [`DriverVTable`] ensure that all elements of the `drivers` slice
>>>>> // are initialized properly. So an FFI call with a valid pointer.
>>>>> to_result(unsafe {
>>>>> bindings::phy_drivers_register(ptr, reg.drivers.len().try_into()?, module.0)
>>>>> })?;
>>>>> // INVARIANT: The `drivers` slice is successfully registered to the kernel via `phy_drivers_register`.
>>>>> Ok(reg)
>>>>> }
>>>>> }
>>>>
>>>> Scratch this.
>>>>
>>>> This doesn't work. Also simply putting slice of DriverVTable into
>>>> Module strcut doesn't work.
>>>
>>> Why does it not work? I tried it and it compiled fine for me.
>>
>> You can compile but the kernel crashes. The addresses of the callback
>> functions are invalid.
>
> Can you please share your setup and the error? For me it booted
>fine.
You use ASIX PHY hardware?
I use the following macro:
(drivers: [$($driver:ident),+], device_table: [$($dev:expr),+], $($f:tt)*) => {
const N: usize = $crate::module_phy_driver!(@count_devices $($driver),+);
struct Module {
_drivers: [::kernel::net::phy::DriverVTable; N],
}
$crate::prelude::module! {
type: Module,
$($f)*
}
unsafe impl Sync for Module {}
impl ::kernel::Module for Module {
fn init(module: &'static ThisModule) -> Result<Self> {
let mut m = Module {
_drivers:[$(::kernel::net::phy::create_phy_driver::<$driver>()),+],
};
let ptr = m._drivers.as_mut_ptr().cast::<::kernel::bindings::phy_driver>();
::kernel::error::to_result(unsafe {
kernel::bindings::phy_drivers_register(ptr, m._drivers.len().try_into()?, module.as_ptr())
})?;
Ok(m)
}
}
[ 176.809218] asix 1-7:1.0 (unnamed net_device) (uninitialized): PHY [usb-001:003:10] driver [Asix Electronics AX88772A] (irq=POLL)
[ 176.812371] Asix Electronics AX88772A usb-001:003:10: attached PHY driver (mii_bus:phy_addr=usb-001:003:10, irq=POLL)
[ 176.812840] asix 1-7:1.0 eth0: register 'asix' at usb-0000:00:14.0-7, ASIX AX88772 USB 2.0 Ethernet, 08:6d:41:e4:30:66
[ 176.812927] usbcore: registered new interface driver asix
[ 176.816371] asix 1-7:1.0 enx086d41e43066: renamed from eth0
[ 176.872711] asix 1-7:1.0 enx086d41e43066: configuring for phy/internal link mode
[ 179.002965] asix 1-7:1.0 enx086d41e43066: Link is Up - 100Mbps/Full - flow control off
[ 319.672300] loop0: detected capacity change from 0 to 8
[ 367.936371] asix 1-7:1.0 enx086d41e43066: Link is Down
[ 370.459947] asix 1-7:1.0 enx086d41e43066: configuring for phy/internal link mode
[ 372.599320] asix 1-7:1.0 enx086d41e43066: Link is Up - 100Mbps/Full - flow control off
[ 615.277509] BUG: unable to handle page fault for address: ffffc90000752e98
[ 615.277598] #PF: supervisor read access in kernel mode
[ 615.277653] #PF: error_code(0x0000) - not-present page
[ 615.277706] PGD 100000067 P4D 100000067 PUD 1001f0067 PMD 102dad067 PTE 0
[ 615.277761] Oops: 0000 [#1] PREEMPT SMP
[ 615.277793] CPU: 14 PID: 147 Comm: kworker/14:1 Tainted: G OE 6.6.0-rc4+ #2
[ 615.277877] Hardware name: HP HP Slim Desktop S01-pF3xxx/8B3C, BIOS F.05 02/08/2023
[ 615.277929] Workqueue: events_power_efficient phy_state_machine
[ 615.277978] RIP: 0010:phy_check_link_status+0x28/0xd0
[ 615.278018] Code: 1f 00 0f 1f 44 00 00 55 48 89 e5 41 56 53 f6 87 dd 03 00 00 01 0f 85 ac 00 00 00 49 89 fe 48 8b 87 40 03 00 00 48 85 c0 74 13 <48> 8b 80 10 01 00 00 4c 89 f7 48 85 c0 74 0e ff d0 eb 0f bb fb ff
[ 615.278136] RSP: 0018:ffffc90000823de8 EFLAGS: 00010286
[ 615.278174] RAX: ffffc90000752d88 RBX: ffff8881023524e0 RCX: ffff888102e39980
[ 615.278223] RDX: ffff88846fbb18e8 RSI: 0000000000000000 RDI: ffff888102352000
[ 615.278269] RBP: ffffc90000823df8 R08: 8080808080808080 R09: fefefefefefefeff
[ 615.278316] R10: 0000000000000007 R11: 6666655f7265776f R12: ffff88846fbb18c0
[ 615.278364] R13: ffff888102b75000 R14: ffff888102352000 R15: ffff888102352000
[ 615.278412] FS: 0000000000000000(0000) GS:ffff88846fb80000(0000) knlGS:0000000000000000
[ 615.278491] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 615.278532] CR2: ffffc90000752e98 CR3: 0000000005433000 CR4: 0000000000750ee0
[ 615.278579] PKRU: 55555554
[ 615.278609] Call Trace:
[ 615.278629] <TASK>
[ 615.278649] ? __die_body+0x6b/0xb0
[ 615.278686] ? __die+0x86/0x90
[ 615.278725] ? page_fault_oops+0x369/0x3e0
[ 615.278771] ? usb_control_msg+0xfc/0x140
[ 615.278809] ? kfree+0x82/0x180
[ 615.278838] ? usb_control_msg+0xfc/0x140
[ 615.278871] ? kernelmode_fixup_or_oops+0xd5/0x100
[ 615.278923] ? __bad_area_nosemaphore+0x69/0x290
[ 615.278972] ? bad_area_nosemaphore+0x16/0x20
[ 615.279004] ? do_kern_addr_fault+0x7c/0x90
[ 615.279036] ? exc_page_fault+0xbc/0x220
[ 615.279081] ? asm_exc_page_fault+0x27/0x30
[ 615.279120] ? phy_check_link_status+0x28/0xd0
[ 615.279167] ? mutex_lock+0x14/0x70
[ 615.279198] phy_state_machine+0xb1/0x2c0
[ 615.279231] process_one_work+0x16f/0x3f0
[ 615.279263] ? wq_worker_running+0x11/0x90
[ 615.279310] worker_thread+0x360/0x4c0
[ 615.279351] ? __kthread_parkme+0x4c/0xb0
[ 615.279384] kthread+0xf6/0x120
[ 615.279412] ? pr_cont_work_flush+0xf0/0xf0
[ 615.279442] ? kthread_blkcg+0x30/0x30
[ 615.279485] ret_from_fork+0x35/0x40
[ 615.279528] ? kthread_blkcg+0x30/0x30
[ 615.279570] ret_from_fork_asm+0x11/0x20
[ 615.279619] </TASK>
[ 615.279644] Modules linked in: asix(E) rust_ax88796b(OE) intel_rapl_msr(E) intel_rapl_common(E) intel_uncore_frequency(E) intel_uncore_frequency_common(E) rtw88_8821ce(E) rtw88_8821c(E) rtw88_pci(E) rtw88_core(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) mac80211(E) coretemp(E) rapl(E) libarc4(E) nls_iso8859_1(E) mei_me(E) intel_cstate(E) input_leds(E) apple_mfi_fastcharge(E) wmi_bmof(E) ee1004(E) cfg80211(E) mei(E) acpi_pad(E) acpi_tad(E) sch_fq_codel(E) msr(E) ramoops(E) reed_solomon(E) pstore_blk(E) pstore_zone(E) efi_pstore(E) ip_tables(E) x_tables(E) hid_generic(E) usbhid(E) hid(E) usbnet(E) phylink(E) mii(E) crct10dif_pclmul(E) crc32_pclmul(E) ghash_clmulni_intel(E) sha512_ssse3(E) r8169(E) aesni_intel(E) crypto_simd(E) cryptd(E) i2c_i801(E) i2c_smbus(E) realtek(E) xhci_pci(E) xhci_pci_renesas(E) video(E) wmi(E) [last unloaded: ax88796b(E)]
[ 615.280107] CR2: ffffc90000752e98
[ 615.280133] ---[ end trace 0000000000000000 ]---
[ 615.365054] RIP: 0010:phy_check_link_status+0x28/0xd0
[ 615.365065] Code: 1f 00 0f 1f 44 00 00 55 48 89 e5 41 56 53 f6 87 dd 03 00 00 01 0f 85 ac 00 00 00 49 89 fe 48 8b 87 40 03 00 00 48 85 c0 74 13 <48> 8b 80 10 01 00 00 4c 89 f7 48 85 c0 74 0e ff d0 eb 0f bb fb ff
[ 615.365104] RSP: 0018:ffffc90000823de8 EFLAGS: 00010286
[ 615.365116] RAX: ffffc90000752d88 RBX: ffff8881023524e0 RCX: ffff888102e39980
[ 615.365130] RDX: ffff88846fbb18e8 RSI: 0000000000000000 RDI: ffff888102352000
[ 615.365144] RBP: ffffc90000823df8 R08: 8080808080808080 R09: fefefefefefefeff
[ 615.365157] R10: 0000000000000007 R11: 6666655f7265776f R12: ffff88846fbb18c0
[ 615.365171] R13: ffff888102b75000 R14: ffff888102352000 R15: ffff888102352000
[ 615.365185] FS: 0000000000000000(0000) GS:ffff88846fb80000(0000) knlGS:0000000000000000
[ 615.365210] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 615.365222] CR2: ffffc90000752e98 CR3: 0000000111635000 CR4: 0000000000750ee0
[ 615.365237] PKRU: 55555554
[ 615.365247] note: kworker/14:1[147] exited with irqs disabled
[ 619.668322] loop0: detected capacity change from 0 to 8
[ 919.664303] loop0: detected capacity change from 0 to 8
[ 1219.660223] loop0: detected capacity change from 0 to 8
[ 1519.656041] loop0: detected capacity change from 0 to 8
[ 1819.651769] loop0: detected capacity change from 0 to 8
[ 2119.647826] loop0: detected capacity change from 0 to 8
[ 2419.643470] loop0: detected capacity change from 0 to 8
Powered by blists - more mailing lists