netdev - Re: [PATCH net-next v5 3/5] WIP rust: add second `bindgen` pass for enum exhaustiveness checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 21 Oct 2023 14:05:53 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: nmi@...aspace.dk, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	andrew@...n.ch, tmgross@...ch.edu, boqun.feng@...il.com, wedsonaf@...il.com, 
	benno.lossin@...ton.me, greg@...ah.com, ojeda@...nel.org
Subject: Re: [PATCH net-next v5 3/5] WIP rust: add second `bindgen` pass for
 enum exhaustiveness checking

On Sat, Oct 21, 2023 at 5:51 AM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> Hmm, this works for me.

Andreas was probably using `O=`, but you were not.

At least that is what I guessed yesterday and what the suggestion I gave fixes.

This is also why sending unfinished work by someone else is not the
best idea. I would also have marked that patch as RFC and put it at
the end perhaps, to make it clearer.

By the way, the patch is missing your SoB. I would recommend using
`--signoff` in Git and b4's `am`, `cherry-pick` etc.

Cheers,
Miguel