netdev - Re: [PATCH] net/handshake: fix file ref count in handshake_nl_accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169808222318.2880.6790391903176852910.git-patchwork-notify@kernel.org>
Date: Mon, 23 Oct 2023 17:30:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Moritz Wanzenböck <moritz.wanzenboeck@...bit.com>@codeaurora.org
Cc: netdev@...r.kernel.org, kernel-tls-handshake@...ts.linux.dev,
 chuck.lever@...cle.com
Subject: Re: [PATCH] net/handshake: fix file ref count in
 handshake_nl_accept_doit()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 19 Oct 2023 14:58:47 +0200 you wrote:
> If req->hr_proto->hp_accept() fail, we call fput() twice:
> Once in the error path, but also a second time because sock->file
> is at that point already associated with the file descriptor. Once
> the task exits, as it would probably do after receiving an error
> reading from netlink, the fd is closed, calling fput() a second time.
> 
> To fix, we move installing the file after the error path for the
> hp_accept() call. In the case of errors we simply put the unused fd.
> In case of success we can use fd_install() to link the sock->file
> to the reserved fd.
> 
> [...]

Here is the summary with links:
  - net/handshake: fix file ref count in handshake_nl_accept_doit()
    https://git.kernel.org/netdev/net/c/7798b59409c3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html