netdev - Re: [PATCH net-next v6 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024201024.6cyoqy5vbctbgtfe@skbuf>
Date: Tue, 24 Oct 2023 23:10:24 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Rob Herring <robh@...nel.org>, linux-arm-kernel@...ts.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	devicetree@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Jakub Kicinski <kuba@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Marek Behún <kabel@...nel.org>,
	Christian Marangi <ansuelsmth@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Gregory Clement <gregory.clement@...tlin.com>
Subject: Re: [PATCH net-next v6 1/7] dt-bindings: net: dsa: Require ports or
 ethernet-ports

On Tue, Oct 24, 2023 at 03:18:13PM +0200, Linus Walleij wrote:
> On Tue, Oct 24, 2023 at 2:48 PM Rob Herring <robh@...nel.org> wrote:
> > On Tue, 24 Oct 2023 11:24:53 +0200, Linus Walleij wrote:
> > > Bindings using dsa.yaml#/$defs/ethernet-ports specify that
> > > a DSA switch node need to have a ports or ethernet-ports
> > > subnode, and that is actually required, so add requirements
> > > using oneOf.
> > >
> > > Suggested-by: Rob Herring <robh@...nel.org>
> > > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> > > ---
> > >  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
> > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
> 
> Oh yeah Krzysztof actually explained to me why these have to have
> two spaces extra.
> 
> Oh well I just keep hitting the robot for testing this.
> 
> Yours,
> Linus Walleij

FWIW, we have a rule in Documentation/process/maintainer-netdev.rst to
not repost more frequently than once every 24 hours. Unfortunately I
don't have a huge review capacity right now, so in my case it could
probably take even a bit more than that. But it's a bit unpleasant that
I left some feedback on v4, you posted v5 yesterday and since then we're
now at v7, only for me to find that I need to repeat my v4 feedback.