netdev - Re: [PATCH net-next] net: hns3: add some link modes for hisilicon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <320656f5-5f6a-4d5c-a028-98d4a1b0dd85@huawei.com>
Date: Tue, 24 Oct 2023 11:08:07 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>, "yisen.zhuang@...wei.com"
	<yisen.zhuang@...wei.com>, "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: <shaojijie@...wei.com>, "shenjian15@...wei.com" <shenjian15@...wei.com>,
	"wangjie125@...wei.com" <wangjie125@...wei.com>, "liuyonglong@...wei.com"
	<liuyonglong@...wei.com>, "chenhao418@...wei.com" <chenhao418@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: hns3: add some link modes for hisilicon
 device


on 2023/10/23 16:55, Drewek, Wojciech wrote:
>
>
>   }
>
> +static const struct hclge_link_mode_bit_map hclge_sr_link_mode_bit_map[8] = {
> Names of those arrays are a bit too long. I know this is a standard here but I'm not sure if
> "bit_map" at the end is necessary.

"bit_map" will change to "bmap" in v2 patch，and the structure name will 
be changed together.

>> +	{HCLGE_SUPPORT_10G_BIT, ETHTOOL_LINK_MODE_10000baseSR_Full_BIT},
>> +	{HCLGE_SUPPORT_25G_BIT, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT},
>> +	{HCLGE_SUPPORT_40G_BIT, ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT},
>> +	{HCLGE_SUPPORT_50G_R2_BIT, ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT},
>> +		if (speed_ability & hclge_sr_link_mode_bit_map[i].support_bit)
>> +			linkmode_set_bit(
> Checkpatch complains about wrong wrapping (here and in the next 3 functions):
> CHECK: Lines should not end with a '('
>
>> +				hclge_sr_link_mode_bit_map[i].link_mode,
>> +				link_mode);
>> +	}
>>   }

this wrong wrapping will disappear if "bit_map" change to "bmap".

Thanks.