lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 24 Oct 2023 10:01:56 +0200 (CEST)
From: Romain Gantois <romain.gantois@...tlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
cc: Romain Gantois <romain.gantois@...tlin.com>, davem@...emloft.net, 
    Rob Herring <robh+dt@...nel.org>, 
    Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
    Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
    Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
    linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
    thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>, 
    Florian Fainelli <f.fainelli@...il.com>, 
    Heiner Kallweit <hkallweit1@...il.com>, 
    Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, 
    Vladimir Oltean <vladimir.oltean@....com>, 
    Luka Perkov <luka.perkov@...tura.hr>, 
    Robert Marko <robert.marko@...tura.hr>, Andy Gross <agross@...nel.org>, 
    Bjorn Andersson <andersson@...nel.org>, 
    Konrad Dybcio <konrad.dybcio@...ainline.org>, 
    Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm
 IPQESS Ethernet switch


Hello Krzystof,

On Mon, 23 Oct 2023, Krzysztof Kozlowski wrote:
[...]
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm IPQ4019 Ethernet switch subsystem driver
> 
> Bindings should be about hardware. Please drop "driver". "Subsystem"
> also sounds like Linuxism.

The "driver" part was a mistake, I will drop it. However, the "subsystem" 
terminology seems relevant here, as the SoC documentation refers to this IP 
group as the "Ethernet Switch Subsystem". If it's okay with you, I'll change 
this to "Qualcomm IPQ4019 Ethernet Switch Subsystem (ESS)" in the v2.

> > +properties:
> > +  compatible:
> > +    const: qca,ipq4019-qca8337n
> 
> 
> What do you want to express here? ipq4019 is not qca. This is Qualcomm
> (so qcom) SoC.
Agreed, I'll change the compatible.

Thanks,

Romain

Powered by blists - more mailing lists