lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a29b6917-d578-35c4-978d-d57a3bccd63f@kernel.org> Date: Tue, 24 Oct 2023 16:30:27 -0700 (PDT) From: Mat Martineau <martineau@...nel.org> To: Jakub Kicinski <kuba@...nel.org>, Davide Caratti <dcaratti@...hat.com>, Paolo Abeni <pabeni@...hat.com> cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Matthieu Baerts <matttbe@...nel.org>, netdev@...r.kernel.org, mptcp@...ts.linux.dev, Simon Horman <horms@...nel.org> Subject: Re: [PATCH net-next v2 5/7] uapi: mptcp: use header file generated from YAML spec On Tue, 24 Oct 2023, Jakub Kicinski wrote: > On Mon, 23 Oct 2023 11:17:09 -0700 Mat Martineau wrote: >> +/* for backward compatibility */ >> +#define __MPTCP_PM_CMD_AFTER_LAST __MPTCP_PM_CMD_MAX >> +#define __MPTCP_ATTR_AFTER_LAST __MPTCP_ATTR_MAX > > Do you want to intentionally move to the normal naming or would you > prefer to keep the old names? > > We have attr-cnt-name / attr-max-name for migrating existing families. > We can add similar properties for cmd if you prefer, I think that they > were not needed before. I'm not sure if you're offering to add the feature or are asking us (well, Davide) to implement it :) It would be nice to not have to carry these backward compatibility definitions forever, expecially since they're fairly obscure "__*" names. Low stakes for MPTCP alone, but it might be good to have as other netlink interfaces are migrated. Davide & Paolo, what do you think? - Mat
Powered by blists - more mailing lists