netdev - Re: [PATCH net-next 7/9] iavf: use unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024164417.0f76f2a4@kernel.org>
Date: Tue, 24 Oct 2023 16:44:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Michal
 Schmidt <mschmidt@...hat.com>, Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [PATCH net-next 7/9] iavf: use unregister_netdev

On Mon, 23 Oct 2023 16:08:24 -0700 Jacob Keller wrote:
> Use unregister_netdev, which takes rtnl_lock for us. We don't have to
> check the reg_state under rtnl_lock. There's nothing to race with. We
> have just cancelled the finish_config work.

I can't really convince myself that its indeed the case... but either
way if something can register the netdev past the check - the code is
buggy with or without rtnl_lock, so patch seems sane.