netdev - Re: [net-next PATCH v6 09/10] netdev-genl: spec: Add PID in netdev netlink YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b244d3a-70d2-4799-af0f-3191e802a7a8@intel.com>
Date: Tue, 24 Oct 2023 19:25:28 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v6 09/10] netdev-genl: spec: Add PID in netdev
 netlink YAML spec

On 10/24/2023 3:50 PM, Jakub Kicinski wrote:
> On Mon, 23 Oct 2023 18:34:06 -0700 Amritha Nambiar wrote:
>> +        name: pid
>> +        doc: PID of the napi thread
> 
> PID of the NAPI thread, if NAPI is configured to operate in threaded
> mode. If NAPI is not in threaded mode (i.e. uses normal softirq context)
> the attribute will be absent.
> 
>> +        type: s32
> 
> Hm. PIDs can't be negative, right? I'm guessing POSIX defines pid_t
> as signed to store errors. We can make this u32.
> 

Yes, valid PIDs are not negative, negative default PID is mostly for 
error handling (ex: a fork/clone failure). I just used s32 because of 
the POSIX definition. Will change to u32.