netdev - Re: [net-next PATCH v6 08/10] net: Add NAPI IRQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eff8b9ea-0774-4f31-b5b4-34067deff394@intel.com>
Date: Tue, 24 Oct 2023 19:29:00 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Florian Fainelli <f.fainelli@...il.com>, <netdev@...r.kernel.org>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v6 08/10] net: Add NAPI IRQ support

On 10/24/2023 4:29 PM, Florian Fainelli wrote:
> On 10/23/23 18:34, Amritha Nambiar wrote:
>> Add support to associate the interrupt vector number for a
>> NAPI instance.
>>
>> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>> ---
> [snip]
> 
>> +static inline void netif_napi_set_irq(struct napi_struct *napi, int irq)
>> +{
>> +    napi->irq = irq;
>> +}
>> +
>>   /* Default NAPI poll() weight
>>    * Device drivers are strongly advised to not use bigger value
>>    */
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index d02c7a0ce4bc..adf20fa02b93 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -6507,6 +6507,7 @@ void netif_napi_add_weight(struct net_device 
>> *dev, struct napi_struct *napi,
>>        */
>>       if (dev->threaded && napi_kthread_create(napi))
>>           dev->threaded = 0;
>> +    napi->irq = -1;
> 
> Is there a reason you are not using netif_napi_set_irq() here?

Just overlooked this one. Sure, will use netif_napi_set_irq here in v7.