lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANiq72mktqtv2iZSiE6sKJ-gaee_KaEmziqd=a=Vp2ojA+2TPQ@mail.gmail.com> Date: Thu, 26 Oct 2023 12:39:46 +0200 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: FUJITA Tomonori <fujita.tomonori@...il.com> Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, tmgross@...ch.edu, benno.lossin@...ton.me, wedsonaf@...il.com Subject: Re: [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers On Thu, Oct 26, 2023 at 2:16 AM FUJITA Tomonori <fujita.tomonori@...il.com> wrote: > > This patchset adds Rust abstractions for phylib. It doesn't fully > cover the C APIs yet but I think that it's already useful. I implement > two PHY drivers (Asix AX88772A PHYs and Realtek Generic FE-GE). Seems > they work well with real hardware. This patch series has had 8 versions in a month. It would be better to wait more between revisions for this kind of patch series, especially when there is discussion still going on in the previous ones and it is a new "type" of code. I understand you are doing it so that people can see the latest version (and thus focus on that), and that is helpful, but sending versions very quickly when the discussions are ongoing splits the discussions into several versions. That makes it more confusing for reviewers, and essentially discourages people from being able to follow everything. That, in turn, contributes to the problem of reviewers repeating feedback or missing context -- which you said you did not like. Please see https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient Thanks! Cheers, Miguel
Powered by blists - more mailing lists