netdev - Re: [PATCH bpf-next 2/2] netkit: use netlink policy for mode and policy attributes validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f14eda0f-b045-6563-7b18-bbc5bfb009ca@iogearbox.net>
Date: Thu, 26 Oct 2023 14:13:15 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Nikolay Aleksandrov <razor@...ckwall.org>, bpf@...r.kernel.org
Cc: jiri@...nulli.us, netdev@...r.kernel.org, martin.lau@...ux.dev,
 ast@...nel.org, andrii@...nel.org, john.fastabend@...il.com,
 kuba@...nel.org, andrew@...n.ch, toke@...nel.org, toke@...hat.com,
 sdf@...gle.com
Subject: Re: [PATCH bpf-next 2/2] netkit: use netlink policy for mode and
 policy attributes validation

On 10/26/23 11:41 AM, Nikolay Aleksandrov wrote:
> Use netlink's NLA_POLICY_VALIDATE_FN() type for mode and primary/peer
> policy with custom validation functions to return better errors. This
> simplifies the logic a bit and relies on netlink's policy validation.
> We don't have to specify len because the type is NLA_U32 and attribute
> length is enforced by netlink.
> 
> Suggested-by: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Nikolay Aleksandrov <razor@...ckwall.org>

Acked-by: Daniel Borkmann <daniel@...earbox.net>

> ---
>   drivers/net/netkit.c | 66 +++++++++++++++-----------------------------
>   1 file changed, 22 insertions(+), 44 deletions(-)

Looks better indeed, shrinks code a bit, and passes the selftests, thanks
for the suggestion!

Thanks,
Daniel