lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANiq72=QgT2tG3wy5pioTQ9n416kksZrL1791pehwR=1ZGP52w@mail.gmail.com> Date: Thu, 26 Oct 2023 14:22:23 +0200 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: FUJITA Tomonori <fujita.tomonori@...il.com> Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, tmgross@...ch.edu, benno.lossin@...ton.me, wedsonaf@...il.com, ojeda@...nel.org Subject: Re: [PATCH net-next v7 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking On Thu, Oct 26, 2023 at 1:54 PM FUJITA Tomonori <fujita.tomonori@...il.com> wrote: > > Sorry, I totally misunderstand your intention. I thought that the PHY > abstractions needs to be merged with your patch together. > > I'll drop your patch in the next version and focus on my patches. No harm done! I understand you were trying to help, and I apologize if I sounded too harsh. Your abstractions are not blocked on this patch -- they could go in without this, that is why I suggested marking this one as RFC and putting it at the end of the series. The exhaustiveness check here is an extra feature that prevents a class of bugs, which is great, but it does not really affect the abstractions, i.e. there is no unsoundness in your code whether this patch is in or not. I will send the patch soon, and assuming it lands, then you can start using the feature if you wish. I would recommend basing your patches on top of that patch (or `rust-next` when the patch lands), so that your PHY series contains the addition of `check_phy_state`. Cheers, Miguel
Powered by blists - more mailing lists